Fix some :is(), :where() and :matches() bugs.#167
Open
wRAR wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 96.61% 96.83% +0.22%
==========================================
Files 3 3
Lines 885 886 +1
Branches 136 136
==========================================
+ Hits 855 858 +3
Misses 14 14
+ Partials 16 14 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wRAR
marked this pull request as draft
July 16, 2026 04:50
wRAR
marked this pull request as ready for review
July 16, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:is(a,b)mangle the argument after a comma not followed by whitespace:is(*, X)drops the universal argument and becomes over-restrictive:is(:has(X))translates to a never-matching garbage predicate:is(escapes asRuntimeError, notSelectorSyntaxError:matches()isn't testedns|*argument of:is()/:where()/:not()becomes a never-matching literal name test (fixes Incorrect use of XPath name() function #18)name()-literal comparisons don't match node-test semantics under a default namespaceAlso applies to
:matches(alias for:is) and for:where(shares the implementation with:is).Found and fixed by an LLM, all test cases validated manually.